Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove example schemas #559

Merged
merged 1 commit into from
Sep 23, 2020
Merged

remove example schemas #559

merged 1 commit into from
Sep 23, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Aug 31, 2020

fixes #248

public examples here

although none of them seem to be using any of the common definitions yet


could also remove test for these:

@pytest.mark.parametrize(
"example", json_files_params(BASEDIR.parent / "examples" / "schema", "*-*-*.json")
)
def test_load_resource_spec_example_spec_is_valid(example):
with example.open("r", encoding="utf-8") as f:
assert load_resource_spec(f)

@PatMyron PatMyron requested a review from rjlohan August 31, 2020 22:31
Copy link
Contributor

@LaikaN57 LaikaN57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a consumer perspective, there are better public resources to use rather than looking at these examples. I agree with removing these.

@PatMyron PatMyron merged commit 8a3af14 into master Sep 23, 2020
@PatMyron PatMyron deleted the example-schemas branch September 23, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove example schemas in favour of repo pointers
4 participants