standardizing contract test names #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshikg
approved these changes
Aug 31, 2020
Couldn't find any in this repository: |
LaikaN57
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Standardization is great!
On a related note: When I was first learning how to debug these tests, I was trying to read my SAM logs and did not realize that some of the calls were coming from the test fixture functions. Maybe we can somehow hint to devs that they may have to look at the fixture code too to completely trace exactly what order the function calls are happening in.
omkhegde
approved these changes
Jul 6, 2021
narmadn
reviewed
Jul 6, 2021
| @@ -51,14 +51,14 @@ def contract_create_delete(resource_client): | |||
|
|
|||
| @pytest.mark.create | |||
| @skip_not_writable_identifier | |||
| def contract_create_duplicate(created_resource, resource_client): | |||
| def contract_create_create(created_resource, resource_client): | |||
There was a problem hiding this comment.
Gentle reminder- Update any reference to old names in documentation, if not done already.
narmadn
approved these changes
Jul 6, 2021
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
Co-authored-by: Anshika Garg <[email protected]>
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
Co-authored-by: Anshika Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.