Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toBuilder to lombok @Builder annotation #352

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

tylersouthwick
Copy link
Contributor

@tylersouthwick tylersouthwick commented Feb 12, 2021

Issue #, if available:
#331

Description of changes:
Allows an immutable copy of the resource model and pojos to be created, leveraging lombok's toBuilder construct

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution.

the change looks good to me but since it's a change in pojo the CI/CD will always pass. Could you paste some sam test/contract test results to verify that it does not break payload deserialization and works as expected.

@johnttompkins
Copy link
Contributor

thank you for your contribution.

the change looks good to me but since it's a change in pojo the CI/CD will always pass. Could you paste some sam test/contract test results to verify that it does not break payload deserialization and works as expected.

Payload deserialization should be alright I think. This just adds a generated method

@wbingli wbingli merged commit 82ed8f8 into aws-cloudformation:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants