Run cfn init to set up LookoutVision Project resource providers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmalkan
approved these changes
Jan 12, 2021
brouwersn
reviewed
Jan 12, 2021
brouwersn
reviewed
Jan 12, 2021
|
|
||
| // Placeholder for the functionality that could be shared across Create/Read/Update/Delete/List Handlers | ||
|
|
||
| public abstract class BaseHandlerStd extends BaseHandler<CallbackContext> { |
There was a problem hiding this comment.
Just as a best practice, let's not use inheritance as a way to do code re-use once we actually start implementing this stuff. Instead, let's break out common functionality into separate classes and use injection (e.g. Dagger) to provide implementations inside the handlers.
brouwersn
reviewed
Jan 12, 2021
| import software.amazon.cloudformation.proxy.LoggerProxy; | ||
| import software.amazon.cloudformation.proxy.ProxyClient; | ||
|
|
||
| public class AbstractTestBase { |
There was a problem hiding this comment.
Same as above, let's not use inheritance as a way to do code sharing.
brouwersn
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contains the boilerplate code generated by running "cfn init" for "AWS::LookoutVision::Project". The directory name is "aws-lookoutvision-project".
Testing