Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regex to prevent unicode characters #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update regex to prevent unicode characters #25

wants to merge 1 commit into from

Conversation

kddejong
Copy link

Issue #, if available:

Description of changes:

  • JSON schema validates the pattern against the string but since the start/end characters aren't in the regex strings like úa are considered valid but the service will reject them.
  • Remove minLength and maxLength and use the pattern instead. Removes warnings related to using both.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
Copy link
Author

Warnings as noted above: https://github.com/aws-cloudformation/cloudformation-cli/blob/6a5a5a729da5d87bbafd34e5264abc8f727c4278/src/rpdk/core/contract/resource_generator.py#L245-L248

mmaeng
mmaeng approved these changes Oct 19, 2022
View reviewed changes
Copy link

@mmaeng mmaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericzbeard ericzbeard ericzbeard requested changes

@mmaeng mmaeng mmaeng approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kddejong @ericzbeard @mmaeng