Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ModuleVersion's ModulePackage field to "required" #34

Merged

Conversation

kfdarlington
Copy link
Contributor

@kfdarlington kfdarlington commented Dec 9, 2020

I had originally left ModuleVersion's ModulePackage field out of the "required" fields in the schema because it was causing issues with contract tests (i.e. contract tests would fail when attempting a delete operation because the module package field was required, but cannot be read in DescribeType requests and supplied to the delete handler #318). I had temporarily implemented manual validation in the ModuleVersion create handler to check for ModulePackage to compensate.

After building, running the unit tests, and testing these changes manually in my account through a number of create-, update-, and delete-stack operations, I am confident setting ModulePackage as "required" is safe, despite being flagged by the contract tests for the above reason. ModulePackage is not required as input to the delete handler -- only the ARN is.

With this change, the AWS::CloudFormation::ModuleVersion documentation will now agree with the schema as well.

I also added ModuleName to createOnlyProperties, as it should have been.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kfdarlington kfdarlington merged commit 4f4b09b into aws-cloudformation:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants