Add body_digest option to sign_v4/10
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review, merge and release after work (in a couple hours) assuming everything looks good 👌 |
onno-vos-dev
approved these changes
Feb 16, 2024
Co-authored-by: Jonatan Kłosko <[email protected]>
onno-vos-dev
approved these changes
Feb 16, 2024
jonatanklosko
approved these changes
Feb 16, 2024
|
Will release shortly 👌 |
|
@jonatanklosko @wojtekmach I'll try to bring the release train PR #24 along in this change. So bear with me if it won't work right away, I'm on it 👌 |
|
🎉 https://hex.pm/packages/aws_signature/0.3.2 Thanks @jonatanklosko for the review and @wojtekmach for the PRs! |
|
Thanks all, I really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example where this is useful is: wojtekmach/req#301 :)