Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting codedeploy-config-name as input #506

Closed
wants to merge 3 commits into from

Conversation

c-ameron
Copy link

Issue #479 , if available:

Description of changes:

This allows the setting of the config name of the deployment in Code Deploy via the codedeploy-config-name input variable.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@snoworc snoworc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I like it, i like to have fast, normal, slow deployment roll options. depending on environment, time of day, whether manual or automated, risk level of the change, etc. This allows us to do this in the ci/cd flow instead of terraforming a change to the deployment object first.

@c-ameron
Copy link
Author

c-ameron commented Feb 7, 2024

@iamhopaul123 @KollaAdithya are you able to have a look at this PR? Thanks!

@KollaAdithya KollaAdithya changed the title Allow setting codedeploy-config-name as input feat: Allow setting codedeploy-config-name as input Mar 19, 2024
@alekgosk
Copy link

alekgosk commented Mar 27, 2024

Any updates on merging this one? Would love to get away from using a fork as a workaround :)

@amazreech
Copy link
Contributor

Hi @c-ameron,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. We will reach-out if with any questions or suggestions during the review.

In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:

  1. Verify if PR follows semantic pull request conventions.

  2. Resolve any merge conflicts on the PR

  3. Please run npm run package command to update dist/ folder with latest dependencies. This will allow the Package status check to pass.

@amazreech
Copy link
Contributor

Hi, Thank you for your contribution in this PR. We have recently merged a PR that covers these changes. PR #540. The changes will be released as part of next release.

Closing this PR, please feel free to re-open or create additional PRs for other feature requests or support needed.

Thank you!

@amazreech amazreech closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants