Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BunkerWeb #679

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

fl0ppy-d1sk
Copy link

@fl0ppy-d1sk fl0ppy-d1sk commented Apr 26, 2024

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@Ki-er Ki-er added addition Adding new software to the list reviewers wanted Awaiting reviews labels Apr 26, 2024
Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes to be made.

software/bunkerweb.yml Outdated Show resolved Hide resolved
software/bunkerweb.yml Outdated Show resolved Hide resolved
software/bunkerweb.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ryangurn ryangurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will end up failing syntax-checks because of the double quotes around the description. You may want to remove the double quotes from this to prevent the "description does not end with a dot".

Example below is my QST PR and the action that run initially.

@fl0ppy-d1sk
Copy link
Author

I think this will end up failing syntax-checks because of the double quotes around the description. You may want to remove the double quotes from this to prevent the "description does not end with a dot".

Example below is my QST PR and the action that run initially.

* [Action](https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/8810348676/job/24217675492)

* [PR](https://github.com/awesome-selfhosted/awesome-selfhosted-data/pull/674)

Ok, thanks for the tip. Any thoughts @Ki-er ?

I've made the required changes btw.

@Ki-er
Copy link
Collaborator

Ki-er commented Apr 26, 2024

I think this will end up failing syntax-checks because of the double quotes around the description. You may want to remove the double quotes from this to prevent the "description does not end with a dot".

The '.' is at the end of the sentence and does not check for the "". Please leave the ""

@fl0ppy-d1sk
Copy link
Author

Additional commit should fix the workflow.

@fl0ppy-d1sk
Copy link
Author

Okay, K8S is in full uppercase, my bad.

@nodiscc nodiscc removed the reviewers wanted Awaiting reviews label May 15, 2024
- K8S
- Shell
tags:
- Proxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair this should probably go to https://github.com/awesome-foss/awesome-sysadmin?tab=readme-ov-file#web which lists Web servers and Reverse Proxies. The proxy section is for "traditional", outgoing proxies.

I'd like to do some reorganization (possibly move Web Servers/Reverse Proxies back to this list) before merging this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nodiscc,

Thanks for the feedback. I can create a PR on awesome-sysadmin if you prefer ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take care of the reorganization and merge this when I'm done. Assigning this to myself.

@nodiscc nodiscc self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding new software to the list
Development

Successfully merging this pull request may close these issues.

None yet

4 participants