解决 handle.resume 和 return noop_coroutine 的竞争问题。 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microcai
force-pushed
the
fix_face_on_resume_noop_coro
branch
from
5378801 to
361a0a1
Compare
Jackarain
reviewed
Oct 17, 2024
include/ucoro/awaitable.hpp
Outdated
| } | ||
| else | ||
| { | ||
| // 如果执行到这里，说明 resume_coro 肯定没被执行，说明协程唤醒是由 executor 驱动，此时 | ||
| // 即返回 noop_coroutine 即可. | ||
| return std::noop_coroutine(); | ||
| // 即返回 true 即可. 即不切换协程. |
There was a problem hiding this comment.
更清晰的注释：
返回 true 表示将当前协程的控制权通过手动 resume 来恢复执行。
这是微软编译器的一个 bug。只在 debug 模式下有。 不过如果改成 bool 返回值，功能也是相同的。 就绕过了 微软的 bug。
microcai
force-pushed
the
fix_face_on_resume_noop_coro
branch
from
361a0a1 to
d1d375e
Compare
Jackarain
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这是微软编译器的一个 bug。只在 debug 模式下有。
不过如果改成 bool 返回值，功能也是相同的。
就绕过了 微软的 bug。