试试 review 功能 #15
Closed
试试 review 功能 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackarain
reviewed
Oct 13, 2024
| @@ -172,7 +172,7 @@ namespace ucoro | |||
|
|
|||
| template <typename A> | |||
| requires(detail::is_awaiter_v<std::decay_t<A>>) | |||
| auto await_transform(A&& awaiter) const | |||
| A&& await_transform(A&& awaiter) const | |||
| { | |||
| static_assert(std::is_rvalue_reference_v<decltype(awaiter)>, "co_await must be used on rvalue"); | |||
| return std::forward<A>(awaiter); | |||
There was a problem hiding this comment.
move 和 forward ， 最后都是 static_cast<A&&> 吧。
Jackarain
approved these changes
Oct 13, 2024
|
|
microcai
force-pushed
the
for_review_test
branch
from
cf2a55b to
7d7d625
Compare
|
status report 这个看来永不起来。 |
Jackarain
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.