Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: audit logs #2703

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

feature: audit logs #2703

wants to merge 25 commits into from

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob marked this pull request as draft April 18, 2024 13:42
@Paul-Bob Paul-Bob self-assigned this Apr 18, 2024
Copy link

codeclimate bot commented Apr 18, 2024

Code Climate has analyzed commit 8840724 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

app/helpers/avo/application_helper.rb Outdated Show resolved Hide resolved
lib/avo/configuration.rb Outdated Show resolved Hide resolved
lib/avo/configuration.rb Show resolved Hide resolved
@@ -160,7 +162,9 @@ def license=(value)
def license
gems = Gem::Specification.map {|gem| gem.name}

@license ||= if gems.include?("avo-advanced")
@license ||= if gems.include?("avo-audits")
"enterprise"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? 😢

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consider moving the audit feature to the advanced plan?

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 12, 2024
@Paul-Bob Paul-Bob removed the Stale label May 13, 2024
lib/avo/configuration.rb Outdated Show resolved Hide resolved
lib/avo/configuration.rb Outdated Show resolved Hide resolved
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 30, 2024
@adrianthedev adrianthedev added Stale exempt Task Something to get done Enterprise and removed Stale labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants