add new items #5295
add new items #5295
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
|
Quero aprender algumas coisas com vc |
sorry, I don't speak portuguese. |
There was a problem hiding this comment.
- You have not followed the PR template, no code coverage is being measured in all the projects. No testing is being done.
- https://gitlab.com/moqsien/gvc_resources is vendoring software, why not download from the upstream, how can your users trust you to not inject malware among one of them?
- I cannot accept these projects as they are, I need input from @cassiobotaro and @avelino on this, these projects all seem slightly risky given they are intending to replace
go buildand a version manager and a terminal command recorder, all sensitive things.
| @@ -3172,6 +3172,7 @@ _Software written in Go._ | |||
|
|
|||
| - [abbreviate](https://github.com/dnnrly/abbreviate) - abbreviate is a tool turning long strings in to shorter ones with configurable separators, for example to embed branch names in to deployment stack IDs. | |||
| - [aptly](https://github.com/smira/aptly) - aptly is a Debian repository management tool. | |||
| - [asciinema](https://github.com/gvcgo/asciinema) - A cross-platform asciinema(v2) terminal session recorder for MacOS/Linux/Windows. | |||
There was a problem hiding this comment.
I won't accept this Asciinema because maintaining a separate Go fork seems unnecessary given the active development of the original project. Also, your README doesn't mention that it's an unofficial Go fork based on Asciinema's own Golang code from securisec/asciinema, which is GPL licensed. Your project being MIT licensed is considered a violation since you can't change licenses like that.
| @@ -3254,6 +3256,7 @@ _Software written in Go._ | |||
| - [trubka](https://github.com/xitonix/trubka) - A CLI tool to manage and troubleshoot Apache Kafka clusters with the ability of generically publishing/consuming protocol buffer and plain text events to/from Kafka. | |||
| - [uTask](https://github.com/ovh/utask) - Automation engine that models and executes business processes declared in yaml. | |||
| - [Vegeta](https://github.com/tsenart/vegeta) - HTTP load testing tool and library. It's over 9000! | |||
| - [version-manager](https://github.com/gvcgo/version-manager) - A general version manager for multiple SDKs, such as Go, Java, Node.js, Python, .Net, etc. | |||
There was a problem hiding this comment.
https://github.com/gvcgo/resources seems to be the underlying version tracker. Which you are updating using your account automation. With a lot of empty commits https://github.com/gvcgo/resources/commits/main/
- gvcgo/resources@c1a4854
- gvcgo/resources@25eae64
- gvcgo/resources@1a5f082
This is a supply chain attack waiting to happen, you are not even using github actions so people can see what you could commit based on the action logic. I will not be accepting this either.
And also you are packaging your go fork of asciinema with this instead of the official one.
| @@ -3202,6 +3203,7 @@ _Software written in Go._ | |||
| - [go-selfupdate](https://github.com/sanbornm/go-selfupdate) - Enable your Go applications to self update. | |||
| - [gobrew](https://github.com/cryptojuice/gobrew) - gobrew lets you easily switch between multiple versions of go. | |||
| - [gobrew](https://github.com/kevincobain2000/gobrew) - Go version manager. Super simple tool to install and manage Go versions. Install go without root. Gobrew doesn't require shell rehash. | |||
| - [gobuilder](https://github.com/gvcgo/gobuilder) - An enhancement for official go build. | |||
There was a problem hiding this comment.
Has no documentation on how to use all the features that are mentioned in the readme.
Replacing $ with # is unncessary when "$(git ...)" is a bash command which gets replaced even before it gets passed to the executable as an argument.
As per awesome-go guidelines 80% code coverage is required, your readme has no links to code coverage.
It is unclear what this tool does without running it, and it is only a 3 week project at v0.0.5, awesome-go requires a stable v1.0.0 release.
phanirithvij
added
needs tests
pending-submitter-response
need coverage
just one package
I looked at the projects that are in this PR and I also consider it risky to list the projects in awesome-go (in some way we are recommending), in my perspective it doesn't make sense for the projects to be in awesome-go!
Before contributing, it is important to read the contribution guide - the paragraph mentioned above is in the guide. |
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 馃槑