update no-unknown-modifier rules, resolve #107 #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
#102 already covers You need to rebase, and drop the |
add failing modifier
Contributor
Author
|
@jamestalmage rebased |
Contributor
|
LGTM! We will wait for avajs/ava#831 to land before merging. Thanks @cgcgbcbc! |
Contributor
|
LGTM, thanks @cgcgbcbc :) |
Contributor
|
Somebody should write a bot that would notify you in this thread, when the thread you are watching gets closed / merged. Would have been better to merge this right after #831 landed so we weren't risking making the contributor rebase (he didn't end up having to, which is good, but it would be annoying if he did because we just forgot this was sitting here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add always, failing modifier. resolve #107