Skip to content

use explicity structs and innervm calls #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Jun 16, 2025

Why this should be merged

There were few reviews in #1009 after it was merged. This PR intends to responde those.

How this works

This pull request refactors the atomic sync components in the EVM plugin to improve clarity and maintainability. Key changes include renaming internal types to exported ones, enhancing comments for better documentation, and updating initialization logic to align with the new architecture.

Refactoring of sync components:

  • plugin/evm/atomic/sync/extender.go: Renamed extender to Extender and updated comments to clarify its role as the sync extender for the atomic VM. Updated methods to align with the new exported type. [1] [2] [3]

  • plugin/evm/atomic/sync/summary_provider.go: Renamed summaryProvider to SummaryProvider and updated comments to describe its role in providing state summaries for the atomic trie. Adjusted initialization logic to match the new exported type.

Updates to VM initialization logic:

  • plugin/evm/atomic/vm/vm.go: Updated initialization of sync.Extender and sync.SummaryProvider to use exported types. Adjusted initialization of dependent components (atomicBackend, atomicTrie, and leafHandler) to improve clarity and consistency. [1] [2]

Minor corrections:

How this was tested

Existing tests

Need to be documented?

No

Need to update RELEASES.md?

No

@ceyonur ceyonur marked this pull request as ready for review June 16, 2025 13:12
@ceyonur ceyonur requested a review from a team as a code owner June 16, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant