move atomic backend and consensus callbacks #1011
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Jun 7, 2025
There was a problem hiding this comment.
all of the removed lines moved to atomic/vm
There was a problem hiding this comment.
To what extent were they changed? Was it a copy/paste, or more complicated than that? Everything else LGTM and I'm just trying to gauge how thoroughly that part needs to be reviewed.
There was a problem hiding this comment.
Most of them stays pretty much same but it won't hurt to check diffs in function-by-function, or whatever method you prefer as a reviewer.
alarso16
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #986
Why this should be merged
Moves atomic backend, repository and fx interface to atomic vm
How this works
This pull request primarily focuses on refactoring and improving the extensibility of the EVM plugin by introducing new interfaces and simplifying existing code. Key changes include the removal of redundant methods, updates to references for atomic VM components, and enhancements to configuration and testing logic.
Refactoring and Code Simplification:
AtomicBackend()method from theVMimplementation and replaced direct calls to it with references toatomicVM.AtomicBackend. This change simplifies the code and aligns it with the updated structure. (plugin/evm/atomic/vm/block_extension.go: [1] [2] [3] [4]plugin/evm/vm_extensible.goand added new methods to exposeVersionDBandChainConfig. (plugin/evm/vm_extensible.go: [1] [2]Updates to Testing Logic:
atomicVMreferences instead of direct VM components, ensuring consistency with the refactored code. (plugin/evm/export_tx_test.go: [1] [2] [3];plugin/evm/tx_test.go: [4];plugin/evm/vm_test.go: [5] [6]Enhancements to Configuration:
ExtensibleVMinterface, includingChainConfig,ReadLastAccepted, andVersionDB, to improve extensibility and provide better access to VM configurations. (plugin/evm/extension/config.go: [1] [2]File Renaming:
plugin/evm/bonus_blocks.gotoplugin/evm/atomic/vm/bonus_blocks.goto better reflect its purpose and location within the atomic VM structure. (plugin/evm/atomic/vm/bonus_blocks.go: plugin/evm/atomic/vm/bonus_blocks.goL3-R3)How this was tested
Existing tests
Need to be documented?
No
Need to update RELEASES.md?
No