Incorrect implimentation in planning/behavior_velocity_no_stopping_area_module

[veqcc]

Checklist

• I've read the contribution guidelines.
• I've searched other issues and no duplicate issues were found.
• I'm convinced that this is not my fault but a bug.

Description

This is a dicussion in #6986.

After #6517, the variable dist_from_area_sum is not used anymore in generateEgoNoStoppingAreaLanePolygon function in behavior_velocity_no_stopping_area_module.
See

autoware.universe/planning/behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp

Line 331 in b0a0a39

double dist_from_area_sum = 0.0;

In other words, the parameter margin is also unused, and in tern the following calculations seems incorrect:
https://github.com/autowarefoundation/autoware.universe/blob/b0a0a3993c7c5c46e2d79a1b8cd3c27856bbf796/planning/behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp#L149C3-L160C43

  const auto & vi = planner_data_->vehicle_info_;
  const double margin = planner_param_.stop_line_margin;
  const double ego_space_in_front_of_stuck_vehicle =
    margin + vi.vehicle_length_m + planner_param_.stuck_vehicle_front_margin;
  const Polygon2d stuck_vehicle_detect_area = generateEgoNoStoppingAreaLanePolygon(
    *path, current_pose->pose, ego_space_in_front_of_stuck_vehicle,
    planner_param_.detection_area_length);
  const double ego_space_in_front_of_stop_line =
    margin + planner_param_.stop_margin + vi.rear_overhang_m;
  const Polygon2d stop_line_detect_area = generateEgoNoStoppingAreaLanePolygon(
    *path, current_pose->pose, ego_space_in_front_of_stop_line,
    planner_param_.detection_area_length);

Since the parameter margin is unused, the two variables stuck_vehicle_detect_area and stop_line_detect_area would be exactly the same values.

Expected behavior

I do not know the expected behavior here, but I think the current implementation is different from what the maintainer expects.

Actual behavior

I don't know.

Steps to reproduce

If you run cppcheck, you can find dist_from_area_sum related warning.

Versions

No response

Possible causes

No response

Additional context

No response

[veqcc]

@kosuke55
When can you work on it?

[shmpwk]

@veqcc
@kosuke55 asked person in collaborative company.

[kosuke55]

@veqcc @shmpwk
thanks for your report and remind.
I discussed with @kaigohirao san and now working on this.

( tieriv internal link :https://star4.slack.com/archives/C05UHMNSE5C/p1716538183388229?thread_ts=1716537613.291899&cid=C05UHMNSE5C)

[idorobotics]

Closed by #6986

[kosuke55]

fixed by #7280