Add ability to read config variables from env #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocGarbanzo
requested changes
Sep 14, 2021
| @@ -51,19 +61,20 @@ def load_config(config_path=None, myconfig="myconfig.py"): | |||
| if os.path.exists(local_config): | |||
| config_path = local_config | |||
|
|
|||
| print('loading config file: {}'.format(config_path)) | |||
| logger = getLogger() | |||
| logger.info('loading config file: {}' . format(config_path)) | |||
There was a problem hiding this comment.
Great, we should be moving to logging. Can you please also use f-strings?
|
@altexdim - do you want to address the comments so we can merge this? |
|
Yes, absolutely, thank you for the review, I'll fix it as I find some time |
|
@DocGarbanzo if we like this feature (I like it), we should change that to f-string ourselves or merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to read config variables from env
Usage example:
DONKEYCAR_CFG_MAX_LOOPS=2000 python manage.py drivethis command will override config variable MAX_LOOPS and set it to 2000
this is the equivalent of having MAX_LOOPS=2000 in the myconfig.py