Update PCA9685 driver to latest Adafruit CircuitPython driver #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change pi and nano install to install the new driver. - update pins.py to use new driver to provide output and pwm pins on a PCA9685 board. - Change the PCA9685 actuator to be a subclass of PulseController, so it inherits the underlying pin provider and pulse controller api. This elimnates the duplicate code in pins.py and actuator.py.
Ezward
force-pushed
the
1177-update-i2c-driver-for-bookwork
branch
from
1bff13f
to
bca136a
Compare
|
I tested this with a RaspberryPi 5 and PCA9685 and a servo using the calibrate command. It worked as expected. I think we still want to test on an actual car before we release it. |
|
The code as-is (commmit bca136a) has a bug in the throttle somewhere. Steering works correctly, but throttle does not. This is likely in the PwmThrottle part and how it interacts with the pin, possibly how the pin is started. However, I have also found that we don't really need this update; the current code works perfectly fine on a RaspberrPi 5 using the latest RaspberryPi OS (bookworm), so I'm pausing work on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177
change pi and nano install to install the new driver.
update pins.py to use new driver to provide output and pwm pins on a PCA9685 board.
Change the PCA9685 actuator to be a subclass of PulseController, so it inherits the underlying pin provider and pulse controller api. This elimnates the duplicate code in pins.py and actuator.py.
Test PCA9685 drivetrains on RaspberryPi 4
Test PCA9685 drivetrains on RaspberryPi 5
Test PCA9685 drivetrains on Jetson Nano
Test I2c OLED