Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LUA_VERSION if set to identify LuaRocks manifest to search #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Nov 16, 2024

Follow up to #313, makes the LuaRocks macro useful for projects that have chosen LuaJIT.

@alerque alerque marked this pull request as ready for review November 16, 2024 23:15
@alerque alerque force-pushed the luarocks-luaversion branch from 82376d1 to f0a1eae Compare November 16, 2024 23:17
@alerque alerque marked this pull request as draft November 16, 2024 23:20
It is quite common to have more than one Lua VM available, and
`luarocks` will typically default to one that the system has suggested
as the default. This may or not be the one a developer is trying to
target, especially if LuaJIT is allowable. The AX_PROG_LUA macro now has
detection support for LuaJIT, and this very likely will *not* be the VM
that LuaRocks defaults to looking for.

With this, any previous use of AX_PROG_LUA will have set the variable
LUA_VERSION, and if so `luarocks` will search for manifests matching
that version. This way LuaJIT (which uses 5.1 versioning) can be queried
for compatible rocks even if the system default is 5.4 or similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant