AppleClang15 patch #116
Merged
AppleClang15 patch #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer used on arm architectures\n- NEON SIMD option only auto selected on arm architectures, defaults to AVX otherwise\n- polar() function now defaults arg2 to 0.0 rather than throwing an error/ignoring overload\n- <StdCompatibility.cpp> auto included for arm & appleclang15\n - One test changed in Complex_test.cpp to prevent overload error. This is a temporary change and the test will be restored once the error related to std::norm is fixed\n - Added Mac Clang15 workflow (debug & release) to ci.yml (yet to test)
- Proper overload for std::norm now selected when norm is called with type param. - Added NEON SIMD option to drop down menu for CMake GUI - Restored test I previously changed
auto-differentiation-dev
requested changes
May 28, 2024
|
Regarding the failing Windows toolset 14.1 build, could you change the CI/CD so that MSVC 14.0 and 14.1 are using the runner image |
- M1 workflow no longer needlessly installs llvm15 - Fixed erroneous formatting error & redundant flag addition - SIMD: NEON -> APPLE_M1, & added NATIVE - norm overloads now use = Constructor() rather than = 0 where relevant - Removed redundant include of <StdCompatibility.hpp> in XAD.hpp - Windows 14.1 build now uses 2019 runner
auto-differentiation-dev
requested changes
May 30, 2024
|
Given the differences between the different compiler versions and Mac architectures, I believe we should extend the CI/CD build into a wider matrix build (similar to Linux/Windows). You can see here that both Arm and Intel based runners are available, and we have Clang 14/15 to test with on each. Plus Debug/Release and coverage. If you want to do that as part of this PR, that would be great. Otherwise it could also be done in a separate one. |
- Changed APPLE_M1 flag -march=apple-m1 -> -march=armv8.5-a - Removed redundant GNU branch in SetupCompiler.cmake - Added better system resolve (Darwin/Linux) in SetupOptions.cmake - Changed overload for norm as to enable if type is XAD rather than disable if type is a c++ native type This fix intends to fix the flag issue for the macoslatest workflow. It may not; in which case this task is relayed it to the next commit. Next fix will fix baseline coverage issues for Mac (Debug)
- Merged macos-13 & macos-latest into wider matrix build. - Changed Mac (Debug) to use [email protected] rather than [email protected] to try fix coverage baseline issue. - Changed Expressions_test 1686 to use tolerance value rather than DOUBLE_EQ. The lcov version downgrade may not fix coverage baseline, in which case that change will be reverted
Pull Request Test Coverage Report for Build 9364361988Details
💛 - Coveralls |
auto-differentiation-dev
requested changes
Jun 4, 2024
auto-differentiation-dev
approved these changes
Jun 4, 2024
auto-differentiation-dev
merged commit 1b8be41
into
auto-differentiation:main
58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mac Silicon compatibility fix. Aims to resolve Apple Silicon Support #99. Includes:
NATIVEandAPPLE_M1SIMD optionsmacos-13&macos-latest, Debug and ReleaseAdditional non-issue related changes:
2.1->1.14to repair coverage baseline issusesType of change