adds optional revision in LookupPermissionSets #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the introduction of BreakingSchemaChange, clients will be notified that an incompatible change has happened and that they need rebuild their index. In order to do that, they need to call LookupPermissionSets with the revision at which the breaking event happened. This introduces an optional revision in LookupPermissionSets to support this use-case.
ecordell
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
We had some offline discussion about how this is potentially confusing, since you won't be able to pass in any zedtoken and expect it to work.
But we decided that this is okay for now, and for v0, and we can revisit as we move out of EA and into GA for materialize.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction of BreakingSchemaChange,
clients will be notified that an incompatible change has happened and that they need rebuild their index. In order to do that, they need to call LookupPermissionSets with the revision at which the breaking event happened.
This introduces an optional revision in LookupPermissionSets to support this use-case.