Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce JsonPathJacksonProvider #649

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

baulea
Copy link
Contributor

@baulea baulea commented Mar 23, 2024

Fixes Issue

PR Branch
https://github.com/baulea/zerocode/tree/jsonPathJacksonProvider

Motivation and Context

Move to jackson json provider in JsonPath instead of jsonsmart. Jackson is already used in zerocode, and we can get rid of jsonsmart as another JSON processor.

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@baulea
Copy link
Contributor Author

baulea commented Mar 23, 2024

Hello @a1shadows , would you please have a look at this PR?

@a1shadows
Copy link
Collaborator

@baulea hey it looks like CI is breaking. Can you take a look?

Copy link
Collaborator

@a1shadows a1shadows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI has passed. LGTM

@a1shadows a1shadows merged commit 569a8cd into authorjapps:master Mar 31, 2024
1 check passed
@baulea
Copy link
Contributor Author

baulea commented Mar 31, 2024

Hi @a1shadows ,
thank you for merging and closing.

I've been on vacation last week and didn't respond to your question regarding the broken CI test. On my local machine all tests had run successfully (mvn clean install in main directory) before creating the PR and I could not reproduce the problem with the broken test.

Could you image any reason, why sometimes the CI test on GitHub seems to fail, and the next CI test is successful again without changes to the codebase in between?

@a1shadows
Copy link
Collaborator

@baulea all the CI started succeeding after a pull from master. Not sure why the tests were failing before but the pull from master seemed to have fixed the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants