Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-58 #Codecov configuration to check code coverage #119

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aghorpade
Copy link
Collaborator

@aghorpade aghorpade commented Aug 19, 2018

To add code coverage -
How do we integrate it with GitHub?
Sign up in codecov.io via your GitHub account, give access to repository on which report has to be generated.
Once pull request is merged, code coverage will be generated on codecov.io website then you can add that report link in README.md

@codecov-io
Copy link

codecov-io commented Aug 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3d438b2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage          ?   69.24%           
=========================================
  Files             ?       91           
  Lines             ?     2279           
  Branches          ?      213           
=========================================
  Hits              ?     1578           
  Misses            ?      620           
  Partials          ?       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d438b2...a146562. Read the comment docs.

#ignore tag- all files which are not "meant" to be unit-tested, like GUI and constants-files
# so coverage percent won't be reduce by this code.
ignore:
- "zerocode/src/main/java/org/jsmart/zerocode/converter/SoapMocker.java"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
More classes like this to be added ie task on me.


Code Coverage Report
--------------------
Link to see the coverage : http://please-provide-the-link-here
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls provide link for live coverage report please. That's the purpose.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is not generic one. Once you merge this PR, we need to update this link as per zerocde code coverage report.
e.g. link could be similar to - https://codecov.io/gh/aghorpade/zerocode

@@ -231,6 +231,21 @@
<target>${java-compiler-target.version}</target>
</configuration>
</plugin>

<!-- code cov plugin to generate report on code coverage-->
<plugin>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check, do we need the cobertura plugin for local profile? If not, then keep only for release profile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check code coverage on local machine,we will need it in local profile. If there is no need then we can remove it

@authorjapps
Copy link
Owner

ignore section not getting recognized for coverage. probably path is wrong for java files.

Copy link
Owner

@authorjapps authorjapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parking this to prevent accidental merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants