Prevent duplication of roles #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loreith
requested review from
anthonyblond,
seamuslee001,
andrew-cormick-dockery and
johntwyman
|
Could you give some details on the test you performed? I don't think I've ever been able to reliably reproduce this issue. |
I believe the test process is this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stops the runaway duplication of roles.
Previously when roles were loaded programmatically, any action to save would create duplicates of every role the user had in any domains other than the current one.
This patch simply checks that the role being added won't be a duplicate, so avoids potentially altering any existing business logic surrounding this.
Testing
This has been tested in the Australian Greens environment together with the auth0_drupal module.