Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Although `composer.json` specifies a `require-dev` which includes this line: ``` "aura/di": "~4.0", ``` Aura.Auth does not work properly with Aura.Di 4.x. This is because strict type checking in PHP 7.2+ requires that the function signatures for `define()` and `modify()` specify a `void` return type. The PHPUnit tests apparently do not instantiate any object using this provided configuration file (`Common.php`), because to do so throws a fatal error. This change should fix that problem.
- Loading branch information
71c03d4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandonsavage @harikt : Does this seem sufficient to you? Is this something there should be a unit test for?
71c03d4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with this. Sorry for the delay.