Address feedback from alecpl #12
jaudrigaci.yml
on: push
Coding Style
1m 28s
Static Analysis
1m 22s
Annotations
10 errors
|
Static Analysis:
plugins/enigma/lib/enigma_ui.php#L1321
Right side of && is always true.
|
|
Static Analysis:
plugins/managesieve/lib/Roundcube/rcube_sieve.php#L188
Comparison operation ">" between 3 and 2 is always true.
|
|
Static Analysis:
program/include/rcmail.php#L750
Negated boolean expression is always false.
|
|
Static Analysis:
program/include/rcmail.php#L754
Comparison operation "==" between rcube_user and 4 results in an error.
|
|
Static Analysis:
program/include/rcmail.php#L764
Call to function is_object() with rcube_user will always evaluate to true.
|
|
Static Analysis:
program/lib/Roundcube/rcube.php#L1895
Method rcube::storage_connect() should return rcube_user but returns int.
|
|
Static Analysis:
program/lib/Roundcube/rcube.php#L1912
Method rcube::storage_connect() should return rcube_user but returns null.
|
|
Static Analysis:
program/lib/Roundcube/rcube_enriched.php#L76
Loose comparison using != between 5 and 5 will always evaluate to false.
|
|
Static Analysis:
program/lib/Roundcube/rcube_enriched.php#L91
Loose comparison using != between 5 and 5 will always evaluate to false.
|
|
Static Analysis:
program/lib/Roundcube/rcube_enriched.php#L118
Loose comparison using != between 4 and 4 will always evaluate to false.
|