Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #20

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

rianbotha
Copy link

@rianbotha rianbotha commented Mar 23, 2018

Please check if the PR fulfills these requirements

  • The commit(s) message(s) follows our guidelines - I found this a bit complicated, but I think I meet the minimum requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) - I don't think any doc change is required

What is the current behavior? (You can also link to an open issue here)
When startOpen is true the drawer does not show since the hiddenOverlay and hiddenDrawer states are also set to true.

What is the new behavior?
hiddenOverlay and hiddenDrawer are set to the inverse of startOpen, which means that the drawer is visible when startOpen is set to true

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants