Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

HACK: Support eclipe.jdt.ls's break with the LSP spec #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

50Wliu
Copy link
Contributor

@50Wliu 50Wliu commented May 28, 2019

This is a rather hacky hack to support eclipse.jdt.ls's custom java.apply.workspaceEdit command that they expect the client to handle.

Originally I tried to implement a way for clients to specify which commands they wanted to handle as suggested in #183, but I ran into issues with being unable to actually follow through with the command. I can get the client to receive the command fine, but since all the logic is still in atom-languageclient, I can't hook into applyWorkspaceEdit or anything of the sort 馃槗. Maybe I'm missing something that would make this approach feasible?

@Aerijo
Copy link
Contributor

Aerijo commented May 29, 2019

Could it be possible to add a command interface that ide-java can hook into on preinitialisation? Like this method but for commands.

As an aside, it seems they make decisions because "it works in VS Code", not because it conforms with the LSP spec. As such, I will now be referring to the Eclipse language server as a VS Code extension that happens to match some of the LSP. I was only half joking just then.

@50Wliu
Copy link
Contributor Author

50Wliu commented Jun 19, 2019

Sorry for the late reply. Yeah, I can add a hook, but the issue still is lack of context. I'll need at the minimum a way to apply a workspace edit from within ide-java.

@hoihoi500
Copy link

Alles komt goed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants