-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
First, thank you for your contribution, it's appreciated. Just by looking at the code, line.split(/\r?\n/|\r/).filter((l)->0 != l.length).map onMessage and see if it helps, without adding multiline flag to regexp. |
Yeah, the new lines at the end threw it off. Your fix solves the problem. Just watch out because you have an extra '/' before the '|' in the regex. Oh, and yeah. I'm on Windows. |
You can just push to branch you requested to pull (master in this case). New commits will be added to pull request. |
Wow. Surprisingly simple. |
Fix handling of various newlines in util-ghc-mod
Merged and published. Thanks! |
No problem. Happy to help. |
Ah. You see, I'm just here to fix bugs and accept pull requests while repo owner is MIA, so I'm not really one to ask this question. It might be a few months before @chaika2013 is back in business. Until then, not much is going on with this project, except occasional bug-squatting. Of course, you are free to look through TODO and issue list and work on anything you feel like. If you do, I'd advise you to create separate branch for each issue and create pull requests early for non-trivial tasks, like here, for example: jgm/pandoc#1968. There is also gitter chat room if you want to discuss something beforehand. So, to answer your question directly, no, nothing in particular. |
I was getting the "got something strange.." warning on every line of output from ghc-mod browse when the output was perfectly fine. This fixes it.