Skip to content
This repository was archived by the owner on Oct 5, 2022. It is now read-only.

Avoid dobule Prettifier unnormal exit message #204

Closed
wants to merge 1 commit into from

Conversation

soiamsoNG
Copy link

Since already notify user by "Prettifier problems" and show the full "stderr"
Advice not notify again in the "Fail to prettify" if the "stderr" not empty.

So a silent exit like spawn error can still catch by "Fail to prettify".

Since already notify user by "Prettifier problems" and show the full "stderr"
Advice not notify again in the "Fail to prettify" if the "stderr" not empty.

So a silent exit like spawn error can still catch by "Fail to prettify".
@lierdakil
Copy link
Contributor

The problem is, having nonempty stderr doesn't necessarily mean that prettifier exited with nonzero exit status (i.e. failed). Can't find the relevant issue right now, but this was a problem a while back. So, the general idea was to let user know if those problems prettifier reported actually lead to hard failure or not (although admittedly, usually they do, regardless of exit code)

@lierdakil lierdakil closed this in 656a71f Aug 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants