This repository was archived by the owner on Oct 5, 2022. It is now read-only.
Reduce CPU used by progress bar, fixes #123 #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when the build progress bar is not visible it frequently causes style recalculation events, constantly waking the CPU up. Instead, we disable the styles when the progress bar is not active.
|
I opted for a slightly different solution, which should work. Check v1.3.4. Thanks for catching this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when the build progress bar is not visible it frequently causes
style recalculation events, constantly waking the CPU up. Instead, we
disable the styles when the progress bar is not active.
I wrote the simplest fix that will work. It might be cleaner to actually remove the ide-haskell-progress-bar element when it isn't needed rather than hide it with CSS.