Prettifier runs in file's directory

[zlondrej]

This change is primarily for stylish-haskell, which searches
for .stylish-haskell.yaml configuration file from current working
directory up to the root. This makes possible to have better controll
of haskell source formatting.

[lierdakil]

Problem is, getPath() doesn't necessarily return a meaningful path (or any path at all). In particular, if you haven't saved buffer yet, this code will break. So there has to be a fallback of some sort. I don't have too much time on my hands, so if you could, that'd be great.

[zlondrej]

Actually it won't break with unsaved buffer. Calling dirname with null or undefined returns . path.
And I can not think of another problem than getPath returning undefined.

Anyway I can put some fallback just in case if you want, but I don't think it's necessary.

[lierdakil]

Huh. It does. My bad. There have been fringe cases where Atom got me something weird, like atom:// uri, though, so here's an idea: check if what you've got is actually a directory, and fallback to . if that isn't the case. That would probably be robust enough.

[zlondrej]

Done.

[lierdakil]

Great, thanks. I'll try to merge/publish by tomorrow (meaning - expect a
release in next 24 hrs)
15 сент. 2015 г. 16:06 пользователь "Ondřej Janošík" <
[email protected]> написал:

Reopened #101 #101.

—
Reply to this email directly or view it on GitHub
#101 (comment).