#187419198 User should interact with each others via chats publicly #48

niyobertin · 2024-05-09T08:32:48Z

What does this PR do?

Have chats room to interact with each other to ask information publicly.
Description of Task to be completed?

Have the following end point
GET: /api/v1/messages
How should this be manually tested?
After cloning the repo, cd into it and run npm run dev to start the server.

using your browser vist http://localhost:PORT/api/v1/messages you will be provided by the link to join the chat room.
provide your username and text your message the send.

Any background context you want to provide?
when a user send a message it will be echoed to all online users

What are the relevant pivotal tracker stories?

[Delivers #187419198]

hound · 2024-05-09T08:32:52Z

public/client.js

+ </li>
+ `
+ chatsRoom.innerHTML += element;
+}


Missing semicolon.

hound · 2024-05-09T08:32:52Z

public/client.js

+}
+
+const addMessageToUi = (isOwner,data) =>{
+ const element = `


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').

hound · 2024-05-09T08:32:52Z

public/client.js

+ active.innerHTML += element;
+}
+
+const addMessageToUi = (isOwner,data) =>{


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T08:32:52Z

public/client.js

+ </li>
+ `
+ active.innerHTML += element;
+}


Missing semicolon.

hound · 2024-05-09T08:32:52Z

public/client.js

+ active.innerHTML += element;
+}
+const onDisConnect = () =>{
+ const element = `


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').

hound · 2024-05-09T08:32:53Z

public/client.js

+ });
+});
+
+const onConnected = () =>{


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T08:32:53Z

public/client.js

+ const messagesList = document.getElementById("messages");
+ messagesList.innerHTML = ""; 
+
+ messages.forEach((msg) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

public/client.js

src/routes/chatRoutes.ts

src/utils/server.ts

public/client.js

hound · 2024-05-09T12:03:33Z

public/client.js

+ const sender = userNameInput.value;
+ const message = messageInput.value;
+
+ socket.emit('chat message', { sender, message });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:33Z

public/client.js

+form.addEventListener("submit", (e) => {
+ e.preventDefault();
+ const sender = userNameInput.value;
+ const message = messageInput.value;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

+const form = document.getElementById('send-message');
+const messageInput = document.getElementById("message-input");
+const userNameInput = document.getElementById("user-name");
+const chatsRoom = document.getElementById("messages");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

+const socket = io();
+const form = document.getElementById('send-message');
+const messageInput = document.getElementById("message-input");
+const userNameInput = document.getElementById("user-name");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

@@ -0,0 +1,74 @@
+const socket = io();
+const form = document.getElementById('send-message');
+const messageInput = document.getElementById("message-input");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

@@ -0,0 +1,74 @@
+const socket = io();
+const form = document.getElementById('send-message');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

@@ -0,0 +1,74 @@
+const socket = io();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:33Z

public/client.js

+ connectedClients.innerHTML = clients;
+});
+
+socket.on('connected client',(clients) =>{


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2024-05-09T12:03:33Z

public/client.js

+ console.log('Connected to server');
+});
+
+socket.on('dis connected client', (clients) =>{


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2024-05-09T12:03:33Z

public/client.js

+ messageInput.value = '';
+});
+
+socket.on('connect', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2024-05-09T12:03:33Z

public/client.js

+ const sender = userNameInput.value;
+ const message = messageInput.value;
+
+ socket.emit('chat message', { sender, message });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

+form.addEventListener("submit", (e) => {
+ e.preventDefault();
+ const sender = userNameInput.value;
+ const message = messageInput.value;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

@@ -0,0 +1,74 @@
+const socket = io();
+const form = document.getElementById('send-message');
+const messageInput = document.getElementById("message-input");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

@@ -0,0 +1,74 @@
+const socket = io();
+const form = document.getElementById('send-message');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

public/client.js

@@ -0,0 +1,74 @@
+const socket = io();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-05-09T12:03:34Z

src/sequelize/migrations/20240506123335-create-message.js

+ allowNull: false,
+ type: Sequelize.DATE
+ }
+ });


Unrecoverable syntax error. (83% scanned).

hound · 2024-05-09T12:03:34Z

src/sequelize/migrations/20240506123335-create-message.js

+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+ async up(queryInterface, Sequelize) {
+ await queryInterface.createTable('messages', {


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-05-09T13:55:47Z

src/sequelize/migrations/20240506123335-create-message.js

+'use strict';
+/** @type {import('sequelize-cli').Migration} */
+module.exports = {
+ async up(queryInterface, Sequelize) {


Expected ':' and instead saw 'up'.
Expected '}' to match '{' from line 3 and instead saw '{'.
Missing semicolon.

hound · 2024-05-09T13:55:48Z

src/sequelize/migrations/20240506123335-create-message.js

@@ -0,0 +1,31 @@
+'use strict';


Use the function form of "use strict".

render · 2024-05-10T15:34:43Z

Your Render PR Server URL is https://eagles-ec-be-development-pr-48.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cov3t4mn7f5s73bep4rg.

codecov-commenter · 2024-05-10T15:53:46Z

Codecov Report

Attention: Patch coverage is 51.25000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 76.73%. Comparing base (daaae6b) to head (0d3b882).

Files	Patch %	Lines
src/controllers/chatsController.ts	26.31%	14 Missing ⚠️
src/services/chatServices.ts	17.64%	14 Missing ⚠️
src/config/socketCofing.ts	35.71%	9 Missing ⚠️
src/services/categories.services.ts	50.00%	1 Missing ⚠️
src/services/product.service.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #48      +/-   ##
==========================================
- Coverage   79.28%   76.73%   -2.56%     
==========================================
  Files          66       73       +7     
  Lines        1178     1255      +77     
  Branches      176      188      +12     
==========================================
+ Hits          934      963      +29     
- Misses        244      292      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yvanddniyo

LGTM

MugemaneBertin2001

LGTM

-an active user when joins the chat should be able to read the past message -an active user should be able to post publlic message -an active when send a message it can be encored to every connected user in real time [#187419198]

#187419198 User should interact with each others via chats publicly

niyobertin requested review from denislohan, MugemaneBertin2001, teerenzo and soleil00 May 9, 2024 08:32

hound bot reviewed May 9, 2024

View reviewed changes

niyobertin requested a review from Heisjabo May 9, 2024 08:33

niyobertin added the IN PROGRESS label May 9, 2024

teerenzo requested changes May 9, 2024

View reviewed changes

src/routes/chatRoutes.ts Outdated Show resolved Hide resolved

src/utils/server.ts Outdated Show resolved Hide resolved

niyobertin force-pushed the 187419198-ft-chats branch from d01cf59 to a1ef798 Compare May 9, 2024 12:03

hound bot reviewed May 9, 2024

View reviewed changes

niyobertin force-pushed the 187419198-ft-chats branch from a1ef798 to a752cb6 Compare May 9, 2024 13:55

hound bot reviewed May 9, 2024

View reviewed changes

niyobertin added READY FOR REVIEW IN PROGRESS and removed IN PROGRESS READY FOR REVIEW labels May 9, 2024

niyobertin force-pushed the 187419198-ft-chats branch from a752cb6 to 4b3e4a6 Compare May 10, 2024 15:34

niyobertin added READY FOR REVIEW REBASING labels May 10, 2024

niyobertin force-pushed the 187419198-ft-chats branch from 4b3e4a6 to ce0aa41 Compare May 10, 2024 15:49

niyobertin removed IN PROGRESS REBASING labels May 10, 2024

niyobertin force-pushed the 187419198-ft-chats branch from ce0aa41 to 6bfe5ea Compare May 14, 2024 04:46

soleil00 requested a review from yvanddniyo May 14, 2024 12:25

niyobertin requested a review from teerenzo May 15, 2024 07:24

yvanddniyo approved these changes May 15, 2024

View reviewed changes

MugemaneBertin2001 approved these changes May 15, 2024

View reviewed changes

teerenzo approved these changes May 15, 2024

View reviewed changes

niyobertin force-pushed the 187419198-ft-chats branch from 6bfe5ea to 0d3b882 Compare May 15, 2024 16:24

yvanddniyo merged commit 3a82f52 into dev May 15, 2024
2 checks passed

MugemaneBertin2001 pushed a commit that referenced this pull request May 15, 2024

Merge pull request #48 from atlp-rwanda/187419198-ft-chats

68331f4

#187419198 User should interact with each others via chats publicly

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#187419198 User should interact with each others via chats publicly #48

#187419198 User should interact with each others via chats publicly #48

niyobertin commented May 9, 2024 •

edited

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

hound bot May 9, 2024

render bot commented May 10, 2024

codecov-commenter commented May 10, 2024 •

edited

yvanddniyo left a comment

MugemaneBertin2001 left a comment

		@@ -0,0 +1,74 @@
		const socket = io();
		const form = document.getElementById('send-message');

#187419198 User should interact with each others via chats publicly #48

#187419198 User should interact with each others via chats publicly #48

Conversation

niyobertin commented May 9, 2024 • edited

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

hound bot May 9, 2024

Choose a reason for hiding this comment

render bot commented May 10, 2024

codecov-commenter commented May 10, 2024 • edited

Codecov Report

yvanddniyo left a comment

Choose a reason for hiding this comment

MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

niyobertin commented May 9, 2024 •

edited

codecov-commenter commented May 10, 2024 •

edited