Fix(auth.controller.ts): Ensure delivery of email which contains token for two factor authentication #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuyishimekyrie
added
the
In progress
tuyishimekyrie
changed the title
tuyishimekyrie
force-pushed
the
fix-send-email-verification
branch
from
ce71563
to
9d02332
Compare
tuyishimekyrie
force-pushed
the
fix-send-email-verification
branch
from
9d02332
to
c543300
Compare
tuyishimekyrie
removed
the
In progress
tuyishimekyrie
added
Ready
SergeInGithub
added
Needs Rebase
and removed
Ready
tuyishimekyrie
added
Ready
src/helpers/sendEmail.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import sendGrid, { MailDataRequired } from '@sendgrid/mail'; | |||
| import dotenv from 'dotenv'; | |||
| import crypto from 'crypto'; | |||
| // import crypto from 'crypto'; | |||
There was a problem hiding this comment.
Suggested change
| // import crypto from 'crypto'; |
SergeInGithub
added
Changes requested
Needs Rebase
and removed
Ready
tuyishimekyrie
dismissed stale reviews from shebz2023, Oliviier-dev, and Aldot-02
via
793962e
tuyishimekyrie
force-pushed
the
fix-send-email-verification
branch
from
c543300
to
793962e
Compare
tuyishimekyrie
added
Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Ensure Correct Token Delivery for Two-Factor Authentication
This commit addresses an issue where the token sent via email for two-factor authentication was not reliably delivered to users, preventing them from verifying their identity for enabling two-factor authentication.
Changes Made:
Endpoints Affected:
These endpoints have been thoroughly tested to confirm the successful delivery of the verification token. Users can now reliably receive and use the token to enable two-factor authentication for their accounts.
This fix enhances the security and usability of the authentication system by ensuring that users can effectively receive tokens through email to verify their identity.
ℹ️ Description
Please write about the changes implemented in this PR. Also write a short description about why the change is implemented.
Fixes #(issue)
🧪 How can this be tested?
📍 Type of change
Please check the options that are relevant.
✅ Checklist: