Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:product search functionality[#187364878] #44

Merged
merged 1 commit into from
May 20, 2024
Merged

feat:product search functionality[#187364878] #44

merged 1 commit into from
May 20, 2024

Conversation

andremugabo
Copy link
Collaborator

@andremugabo andremugabo commented May 13, 2024 •
edited

  • Enable users to search for products by name, price range, category, or a combination of these criteria.
  • Implement search functionality with AND operation to allow users to refine their search results effectively.

[Delivers #187364878]

ℹ️ Description

This pull request enables users to search for products using various criteria such as name, price range, category, or a combination thereof. Additionally, it implements search functionality with an AND operation, allowing users to refine their search results effectively.

Fixes #(issue)

🧪 How can this be tested?

  • Search by Name: Manually enter a product name in the search field and verify that products matching the name are displayed in the search results.
  • Search by Price Range: Enter a price range in the search field and verify that products within that price range are displayed in the search results.
  • Search by Category: Select a category enter it in the search field and verify that products belonging to that category are displayed in the search results.
  • Combination Search: Enter multiple criteria (e.g., name, price range, and category) in the search field and verify that products meeting all criteria are displayed in the search results.
  • Create Jest test cases to cover different aspects of the search functionality. This may include testing:
    • Searching by name, price range, category, and combinations thereof.
    • Ensuring that the search results are accurate and relevant.
    • Testing edge cases, such as empty searches or searches with invalid input.

📍 Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

✅ Checklist:

  • My code follows the style guidelines of this project
  • I have created a loom video for the new feature or enhancement
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@andremugabo andremugabo self-assigned this May 13, 2024
@andremugabo andremugabo added the In progress Use this when you're still working on your task label May 13, 2024
@andremugabo andremugabo force-pushed the ft-user-product-search-187364878 branch 2 times, most recently from 65408f0 to c50f612 Compare May 18, 2024 22:58
@andremugabo andremugabo added Needs Rebase Needs peer reviews Use this when ready for peer reviews and removed In progress Use this when you're still working on your task Needs Rebase labels May 19, 2024
tuyishimekyrie
tuyishimekyrie previously approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@tuyishimekyrie tuyishimekyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ke-bean
Ke-bean previously approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@Ke-bean Ke-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andremugabo andremugabo added Ready Use this when ready for merging and removed Needs peer reviews Use this when ready for peer reviews labels May 19, 2024
@andremugabo andremugabo dismissed stale reviews from Ke-bean and tuyishimekyrie via 44127c2 May 20, 2024 08:30
@andremugabo andremugabo force-pushed the ft-user-product-search-187364878 branch from c50f612 to 44127c2 Compare May 20, 2024 08:30
tuyishimekyrie
tuyishimekyrie previously approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@tuyishimekyrie tuyishimekyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ke-bean
Ke-bean previously approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Ke-bean Ke-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andremugabo andremugabo dismissed stale reviews from Ke-bean and tuyishimekyrie via 032a469 May 20, 2024 10:43
@andremugabo andremugabo force-pushed the ft-user-product-search-187364878 branch from 44127c2 to 032a469 Compare May 20, 2024 10:43
tuyishimekyrie
tuyishimekyrie previously approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@tuyishimekyrie tuyishimekyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeInGithub SergeInGithub removed the Ready Use this when ready for merging label May 20, 2024
@SergeInGithub SergeInGithub added Needs Rebase Needs peer reviews Use this when ready for peer reviews labels May 20, 2024
Ke-bean
Ke-bean previously approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Ke-bean Ke-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andremugabo andremugabo added Ready Use this when ready for merging and removed Needs Rebase Needs peer reviews Use this when ready for peer reviews labels May 20, 2024
SergeInGithub
SergeInGithub reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@SergeInGithub SergeInGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just rebase @andremugabo

@SergeInGithub SergeInGithub added Needs Rebase and removed Ready Use this when ready for merging labels May 20, 2024
@andremugabo andremugabo dismissed stale reviews from Ke-bean and tuyishimekyrie via 6ee171a May 20, 2024 14:34
@andremugabo andremugabo force-pushed the ft-user-product-search-187364878 branch from 032a469 to 6ee171a Compare May 20, 2024 14:34
@andremugabo andremugabo added Ready Use this when ready for merging and removed Needs Rebase labels May 20, 2024
@andremugabo
feat:product search functionality[#187364878]
6ee171a 
- Enable users to search for products by name, price range, category, or a combination of these criteria.
- Implement search functionality with AND operation to allow users to refine their search results effectively.

[Delivers #187364878]
@andremugabo
Copy link
Collaborator Author

Looks good. Just rebase @andremugabo

rebase done, PR #44 is ready

SergeInGithub
SergeInGithub approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@SergeInGithub SergeInGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SergeInGithub SergeInGithub merged commit 7f3b616 into develop May 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeInGithub SergeInGithub SergeInGithub approved these changes

@Ke-bean Ke-bean Ke-bean left review comments

@tuyishimekyrie tuyishimekyrie tuyishimekyrie left review comments

Assignees

@andremugabo andremugabo

Labels
Ready Use this when ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andremugabo @Ke-bean @tuyishimekyrie @SergeInGithub