Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Github-actions): add a command to trigger render on push to develop [#187364845] #36

Conversation

Ke-bean
Copy link
Collaborator

@Ke-bean Ke-bean commented May 9, 2024

ℹ️ Description

This pull request addresses the need for synchronization functionality by adding GitHub Actions commands to trigger rendering upon push events to the develop branch. By automating this process, we ensure that rendering is up-to-date with the latest changes, enhancing our workflow efficiency.

🧪 How can this be tested?

by manually triggering a push event to the develop branch and verifying the rendering process

📍 Type of change

Please check the options that are relevant.

Implemented commands within the workflow to trigger rendering upon push events to the develop branch.

✅ Checklist:

  • My code follows the style guidelines of this project
  • I have created a loom video for the new feature or enhancement
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Ke-bean Ke-bean force-pushed the refactor-github-actions-adding-commands-to-trigger-render branch from 739ea41 to d781271 Compare May 9, 2024 13:10
@Ke-bean Ke-bean self-assigned this May 9, 2024
@Ke-bean Ke-bean added Needs Rebase Needs peer reviews Use this when ready for peer reviews and removed Needs Rebase labels May 9, 2024
@Ke-bean Ke-bean force-pushed the refactor-github-actions-adding-commands-to-trigger-render branch from d781271 to d494813 Compare May 9, 2024 13:18
@Ke-bean Ke-bean changed the title Refactor GitHub actions adding commands to trigger render fix(Github-actions): add a command to trigger render on push to develop [#187364845] May 10, 2024
@Ke-bean Ke-bean force-pushed the refactor-github-actions-adding-commands-to-trigger-render branch from d494813 to 4198815 Compare May 13, 2024 10:05
Comment on lines 44 to 45
with:
service-id: ${{ secrets.RENDER.SERVICE_ID }}
api-key: ${{ secrets.RENDER_API_KEY }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added this secrets in the github environments

Comment on lines 10 to 11
build:

runs-on: ubuntu-latest
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here check properly if build: is on the same level with runs-on

@Ke-bean Ke-bean force-pushed the refactor-github-actions-adding-commands-to-trigger-render branch 7 times, most recently from d04f624 to 7852187 Compare May 16, 2024 09:34
@Ke-bean Ke-bean requested a review from Sagastein May 16, 2024 10:31
Copy link
Collaborator

@shebz2023 shebz2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make a separate PR for admin disabling their account, puting into this PR for github actions doesn't look clean,anyways this was great!

… to develop

add commands to trigger render on push event to develop
@Ke-bean Ke-bean force-pushed the refactor-github-actions-adding-commands-to-trigger-render branch from 7852187 to 8f1dc80 Compare May 16, 2024 11:02
Copy link
Collaborator

@Sagastein Sagastein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@Ke-bean Ke-bean requested a review from shebz2023 May 16, 2024 11:07
Copy link
Collaborator

@shebz2023 shebz2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ke-bean Ke-bean added Ready Use this when ready for merging and removed Needs peer reviews Use this when ready for peer reviews labels May 16, 2024
Copy link
Collaborator

@SergeInGithub SergeInGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeInGithub SergeInGithub merged commit 467c7e8 into develop May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Use this when ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants