Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delivers #187355109] seller can add product] #30

Merged
merged 1 commit into from
May 28, 2024

Conversation

Celestin4
Copy link
Contributor

@Celestin4 Celestin4 commented May 5, 2024

1. What does this PR do?
This PR introduces functionality for sellers to add/create items for sale, ensuring seamless management of stock and providing clients with access to available products.

2. Description of task to be completed

Sellers can add new items for sale.
Validation checks ensure the integrity of the data.
Acceptance criteria include scenarios for item creation and validation.
Acceptance criteria:

Upon receiving a valid request, the system adds the item to the seller's collection.
If the item already exists, the system prevents duplication and suggests updating stock levels.
Error handling is in place for validation failures or unauthorized access.
Dev notes:

Document the API with Swagger for clarity.
Ensure each product has 4-8 images.
Implement thorough input validation.
Store only reference URLs for file uploads.
Establish a reference between products and sellers in the database.

3. How should this be manually tested?

Clone the repository.
Checkout to the branch.
Install necessary dependencies.
Start the development server.
Utilize Swagger documentation to interact with the API.

4. Screenshoota
Tests
image

Swagger documentation

image

Creation of Collection

image

Adding product to creating collection

image image

Copy link

render bot commented May 5, 2024

Copy link

gitguardian bot commented May 5, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

render bot commented May 5, 2024

src/controllers/productController.ts Show resolved Hide resolved
src/helps/cloudinaryConfig.ts Outdated Show resolved Hide resolved
src/routes/productRoutes.ts Show resolved Hide resolved
Copy link

render bot commented May 14, 2024

@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch 4 times, most recently from ab8b78c to f47ba02 Compare May 21, 2024 15:40
@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch from f47ba02 to 9fab6ff Compare May 21, 2024 15:46
src/database/models/collection.ts Show resolved Hide resolved
src/database/models/product.ts Show resolved Hide resolved
@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch 4 times, most recently from bca6f46 to 931db09 Compare May 24, 2024 10:29
src/middleware/isAuthMiddleware.ts Show resolved Hide resolved
src/tests/user.ts Show resolved Hide resolved
@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch 6 times, most recently from f9594db to b7e2dfb Compare May 26, 2024 16:17
src/helps/token.ts Show resolved Hide resolved
src/middleware/multerConfig.ts Show resolved Hide resolved
@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch 4 times, most recently from a1d8602 to 2cbb249 Compare May 26, 2024 17:36
Copy link
Collaborator

@UmuhireJessie UmuhireJessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Celestin4, please work on the comments and resolve the conflicts

@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch 2 times, most recently from 7f28703 to 0a32067 Compare May 27, 2024 15:41
Copy link
Collaborator

@UmuhireJessie UmuhireJessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Celestin4 check my comment

@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch 7 times, most recently from 5483a4a to 1f9361b Compare May 28, 2024 10:20
@Christian-Ishimwe Christian-Ishimwe self-requested a review May 28, 2024 11:01
@Celestin4 Celestin4 force-pushed the ft-seller-can-add-new-product branch from 1f9361b to 16a827e Compare May 28, 2024 15:56
@UmuhireJessie UmuhireJessie merged commit 1523f76 into develop May 28, 2024
5 checks passed
@jniyonkuru jniyonkuru self-requested a review May 28, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants