Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#187364736] Admin can disable account for various reasons #52

Merged
merged 1 commit into from
May 26, 2024

Conversation

mpanoathos
Copy link
Collaborator

@mpanoathos mpanoathos commented May 2, 2024

What does this PR do?

Disabling account for different reasons

Description of Task to be completed?

Admin will be able to disable account for various reasons by changing user status

How should this be manually tested?

  1. Using postman
  2. Swagger

What are the relevant pivotal tracker/Trello stories?

#187364736

Screenshots (if appropriate)

https://www.loom.com/share/20aefa149c344395a3905df58ebcc6d2?sid=1727ecb4-731e-4f22-bf93-74b6aaa3c2d9

@mpanoathos mpanoathos added the WIP Work in progress label May 3, 2024
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch from ef57685 to 4dc110a Compare May 5, 2024 07:26
@coveralls
Copy link

coveralls commented May 5, 2024

Coverage Status

coverage: 94.956% (-0.4%) from 95.374%
when pulling e652902 on ft-admin-change-user-status-187364736
into 9fd9390 on develop.

@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 2 times, most recently from b95329f to 572129a Compare May 5, 2024 17:48
@mpanoathos mpanoathos added Ready for peer review and removed WIP Work in progress labels May 7, 2024
src/controllers/changeStatus.ts Outdated Show resolved Hide resolved
src/controllers/changeStatus.ts Outdated Show resolved Hide resolved
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch from 8ce841e to 201ef5f Compare May 7, 2024 09:52
Copy link

render bot commented May 8, 2024

@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch from 460e166 to d609dda Compare May 8, 2024 08:21
src/controllers/changeStatus.ts Outdated Show resolved Hide resolved
src/controllers/changeStatus.ts Outdated Show resolved Hide resolved
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 3 times, most recently from fa45c75 to 110f20e Compare May 9, 2024 15:28
src/controllers/adminController.ts Outdated Show resolved Hide resolved
src/controllers/adminController.ts Outdated Show resolved Hide resolved
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 6 times, most recently from 8689da2 to 26425b1 Compare May 9, 2024 21:11
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch from 26425b1 to f3627ef Compare May 13, 2024 07:48
Copy link

codeclimate bot commented May 13, 2024

Code Climate has analyzed commit f3627ef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 45.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 17.7% (-82.3% change).

View more on Code Climate.

@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 2 times, most recently from 277a065 to 17270fe Compare May 23, 2024 06:53
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 2 times, most recently from 5846d59 to 11fac21 Compare May 23, 2024 07:09
Copy link
Collaborator

@Yvan-David Yvan-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on working on the reviews and also the whole feature

@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 3 times, most recently from cc1f690 to 9f575bd Compare May 23, 2024 11:17
Copy link
Collaborator

@UwizeyimamaFurahaJustine UwizeyimamaFurahaJustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can work on that request, otherwise you have done a good work.

@mpanoathos mpanoathos removed the request for review from Impano1 May 23, 2024 17:39
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch 6 times, most recently from 0ae9721 to e05be11 Compare May 26, 2024 08:29
@mpanoathos mpanoathos force-pushed the ft-admin-change-user-status-187364736 branch from e05be11 to e652902 Compare May 26, 2024 17:37
@munezerobagira munezerobagira merged commit 83a435c into develop May 26, 2024
8 checks passed
@munezerobagira munezerobagira deleted the ft-admin-change-user-status-187364736 branch May 26, 2024 17:43
AngeloChristian1 pushed a commit that referenced this pull request May 26, 2024
AngeloChristian1 pushed a commit that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants