[#187364733] -Ft two factor authentication for sellers #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
from
822e393
to
bd61670
Compare
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
2 times, most recently
from
0b37f0d
to
f4ed1c5
Compare
EricNiyo73
requested review from
AngeloChristian1,
munezerobagira and
UwizeyimamaFurahaJustine
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
6 times, most recently
from
ded5116
to
0fa3a0a
Compare
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
10 times, most recently
from
2894eff
to
6c5d08d
Compare
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
6 times, most recently
from
3e0a0dc
to
007029c
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
2 times, most recently
from
71742d7
to
88f4ba2
Compare
UwizeyimamaFurahaJustine
approved these changes
May 13, 2024
UwizeyimamaFurahaJustine
approved these changes
May 13, 2024
AngeloChristian1
approved these changes
May 13, 2024
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
from
88f4ba2
to
7167412
Compare
feature(2FA): Two Factor Authentication for Sellers feature(2FA): Two Factor Authentication for Sellers only feature(2FA): Two Factor Authentication for Sellers only
EricNiyo73
force-pushed
the
ft-Two-Factor-Authentication-for-Sellers
branch
from
7167412
to
52b6581
Compare
|
Code Climate has analyzed commit 52b6581 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.2% (0.4% change). View more on Code Climate. |
AngeloChristian1
approved these changes
May 14, 2024
munezerobagira
approved these changes
May 14, 2024
Yvan-David
pushed a commit
that referenced
this pull request
May 14, 2024
feature(2FA): Two Factor Authentication for Sellers [Delivers #187364733] Co-authored-by: Gatete Ishema Angelo Christian <[email protected]>
Yvan-David
pushed a commit
that referenced
this pull request
May 14, 2024
feature(2FA): Two Factor Authentication for Sellers [Delivers #18736473] Co-authored-by: Gatete Ishema Angelo Christian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the functionality for users, specifically Sellers, to enable two-factor authentication (2FA) for added security when logging into the application.
Description of Task to be completed?
The task involves implementing the logic to allow users to enable 2FA for their accounts. When 2FA is enabled for a user, they should be prompted to provide an additional authentication factor, such as an token and OTP code sent via email, during the login process.
How should this be manually tested?
Attempt to log in to the user account with 2FA enabled.
Verify that the login process prompts for a 2FA token i.e jwt token and OTP code sent via email of a user.
Enter a valid 2FA token and submit the form.
Any background context you want to provide?
Verify that the user is successfully logged in after the 2FA token is validated.
Implementing 2FA adds an extra layer of security to user accounts, especially for users with elevated privileges like Sellers who may have access to sensitive data or functionalities.
What are the relevant pivotal tracker/Trello stories?
[#187364733]
Screenshots (if appropriate)
A user try to login with valid credentials, if a userRole is a seller, might get this response.
OTP sent and well received via email.
A user if tries to insert OTP token which is not provided and also that OTP does not corresponded to his/her email
A user finally entered a valid OTP code and authenticated successfully and also token would be generated for login.