Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#187364730]User can login to the app via google #43

Merged
merged 1 commit into from
May 17, 2024
Merged

[#187364730]User can login to the app via google #43

merged 1 commit into from
May 17, 2024

Conversation

mpanoathos
Copy link
Collaborator

@mpanoathos mpanoathos commented Apr 25, 2024 •
edited

What does this PR do?

User is able to login via google

Description of Task to be completed?

  1. Contains configuration of passport (google strategy)
  2. Contains how user will be able to login using google(controllers and routes0

How should this be manually tested?

Using browser

What are the relevant pivotal tracker/Trello stories?

#187364730

Screenshots (if appropriate)

desktop
desktop2
desktop3

@mpanoathos mpanoathos added the WIP Work in progress label Apr 25, 2024
@mpanoathos mpanoathos changed the title [##187364730]User can login to the app via google [#187364730]User can login to the app via google Apr 25, 2024
@mpanoathos mpanoathos force-pushed the ft-google-authentication-187364730 branch from b13c552 to 9168557 Compare April 28, 2024 20:08
codeclimate[bot]
codeclimate bot reviewed May 1, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8854 lines exceeds the maximum allowed for the inline comments feature.

@mpanoathos mpanoathos force-pushed the ft-google-authentication-187364730 branch 5 times, most recently from 07d1693 to 0e93e91 Compare May 3, 2024 04:55
@coveralls
Copy link

coveralls commented May 3, 2024 •
edited

Coverage Status

coverage: 97.15% (+0.1%) from 97.033%
when pulling 7d1efd6 on ft-google-authentication-187364730
into e3d87ff on develop.

@mpanoathos mpanoathos force-pushed the ft-google-authentication-187364730 branch 8 times, most recently from 6b47c72 to 3a194ec Compare May 4, 2024 06:39
@mpanoathos mpanoathos added Ready for peer review and removed WIP Work in progress labels May 4, 2024
@mpanoathos mpanoathos force-pushed the ft-google-authentication-187364730 branch 5 times, most recently from e970ce4 to b14b554 Compare May 5, 2024 09:11
@mpanoathos mpanoathos force-pushed the ft-google-authentication-187364730 branch 5 times, most recently from 2e56147 to 7737d21 Compare May 16, 2024 19:11
@mpanoathos mpanoathos force-pushed the ft-google-authentication-187364730 branch from 7737d21 to 7d1efd6 Compare May 16, 2024 20:20
Bananayosostene
Bananayosostene approved these changes May 17, 2024
View reviewed changes
test/passport.test.ts Outdated Show resolved Hide resolved
@munezerobagira munezerobagira merged commit 84e19d6 into develop May 17, 2024
8 checks passed
mpanoathos added a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
0c8013d 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
a3462d9 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
AngeloChristian1 pushed a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73 @AngeloChristian1
feat(googleauth):User can login to the app via google (#43)
3179e9e 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
AngeloChristian1 pushed a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73 @AngeloChristian1
feat(googleauth):User can login to the app via google (#43)
6718389 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
AngeloChristian1 pushed a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73 @AngeloChristian1
feat(googleauth):User can login to the app via google (#43)
4816632 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
a1d1ab1 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
952b9c3 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 19, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
68f6f70 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 20, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
fb87df2 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 20, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
5272bbf 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 20, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
a97f667 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 20, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
30bd14c 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 20, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
81e157b 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 20, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
f219889 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 21, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
84eb29f 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
mpanoathos added a commit that referenced this pull request May 22, 2024
@mpanoathos @EricNiyo73
feat(googleauth):User can login to the app via google (#43)
68ccaaa 
Co-authored-by: Eric NIYOKWIZERWA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound left review comments

@codeclimate codeclimate[bot] codeclimate left review comments

@munezerobagira munezerobagira munezerobagira approved these changes

@EricNiyo73 EricNiyo73 EricNiyo73 approved these changes

@Bananayosostene Bananayosostene Bananayosostene approved these changes

Assignees
No one assigned
Labels
Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpanoathos @coveralls @munezerobagira @EricNiyo73 @Bananayosostene