Not generate cache for identifier #1796
Conversation
liamqma
requested review from
JakeLane,
pancaspe87,
dddlr and
zesmith2
as code owners
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
🦋 Changeset detectedLatest commit: d2c534c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -128,7 +128,9 @@ describe('css map basic functionality', () => { | |||
|
|
|||
| const styles = cssMap({ root: { color: 'red' } }); | |||
| `); | |||
| }).toThrow(ErrorMessages.USE_VARIANT_OF_CSS_MAP); | |||
| }).toThrow( | |||
| 'This CallExpression was unable to have its styles extracted — try to define them statically using Compiled APIs instead' | |||
There was a problem hiding this comment.
Ah, if this still throws an error…I swore it didn't before, but LGTM. Maybe it's some other scenario that didn't fail…
Is this test sufficient? |
What is this change?
Describe what change you are making here.
Why are we making this change?
Give the full context for your change here.
How are we making this change?
(Optional.)
PR checklist
Don't delete me!
I have...
website/