Conversation
🦋 Changeset detectedLatest commit: 2c9bf78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
itsdouges
reviewed
Dec 21, 2023
…trict `XCSSProp` implementation.
To avoid the complexity of requiring `ReturnType<typeof XCSSProp<…>>` when creating a `createStrictAPI().XCSSProp` and `props.xcss` implementation, being able to use these types in generics are helpful.
The example usage is:
```tsx
const { XCSSProp, css, cssMap, cx } = createStrictAPI<…>();
export type StrictXCSSProp<
TAllowedProperties extends keyof StrictCSSProperties,
TAllowedPseudos extends CSSPseudos,
TRequiredProperties extends {
requiredProperties: TAllowedProperties;
requiredPseudos: TAllowedPseudos;
} = never,
> = ReturnType<
typeof XCSSProp<TAllowedProperties, TAllowedPseudos, TRequiredProperties>
>;
```
Then this becomes a bit easier of a type to understand:
```diff
-export const Component = ({ xcss }: { xcss?: ReturnType<typeof XCSSProp<…>> }) =>
+export const Component = ({ xcss }: { xcss?: StrictXCSSProp<…> }) =>
<div className={xcss} />
```
Particularly when contrasted against the non-createStrictAPI `XCSSProp` type, which is different.
…trictCSSProperties` as it removes some edge-cases.
2a93b6c to
2c9bf78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the complexity of requiring
ReturnType<typeof XCSSProp<…>>when creating acreateStrictAPI().XCSSPropandprops.xcssimplementation, being able to use these types in generics are helpful.The example usage we want is:
Then this becomes a bit easier of a type to understand:
Particularly when contrasted against the non-createStrictAPI
XCSSProptype, which is different.Draft, pending final validation of the idea.