Remove :CHECK-DNS-P and DNS lookups (pending) #3383
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! In the commit 377e9ab a call to
valid-url-p
was replaced withvalid-tld-p
in theinitialize-instance
fornew-url-query
which means that queries likegithub.com/atlas-engineer
are always opened in a search engine ((valid-tld-p "github.com/atals-engineer")
isnil
). After that commitcheck-dns-p
is also never passed tovalid-url-p
, so I remove it.The only place where
check-dns-p
is used is ininitialize-instance
itself. This argument was introduced by me in 485f042 to deal with long latency times when usingset-url
. I cannot remember why I added a check forcheck-dns-p
ininitialize-instance
and now I remove it in this commit.