Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recent buffers #3332

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Fix recent buffers #3332

merged 6 commits into from
Feb 2, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Feb 1, 2024 •
edited

Description

Fixes #3331.

All facilities from recent-buffer.lisp should be fully functional now.

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg aadcg requested a review from jmercouris February 1, 2024 13:11
@aadcg aadcg force-pushed the fix-recent-buffers branch 2 times, most recently from bdb0690 to e8bee9f Compare February 1, 2024 13:42
@aadcg
Copy link
Member Author

aadcg commented Feb 1, 2024 •
edited

@jmercouris above all, the goal of this PR is to ensure that the commands reopen-buffer and reopen-last-buffer are fully functional. If no bugs are spotted, I'd suggest merging.

Note that #3333 is the subject for future work.

@aadcg aadcg mentioned this pull request Feb 1, 2024
Open
@jmercouris
Copy link
Member

I spotted no bugs in my testing.

@aadcg
recent-buffers(reopen-dead-buffer): Propagate changes to reload-buffer.
0a59df8 
Commit 0314bce redefined `reload-buffer', and
this commit should have been part of it.
@aadcg
buffer(add-to-recent-buffers): Fix logic.
8a96be5 
It was a remarkable mistake to delete an item based on a predicate that matches
against the buffer's url and title.
@aadcg
recent-buffers(reopen-dead-buffer): Fix bug.
5549e69 
Closes #3331.
@aadcg
buffer(resurrect-buffer): Minor refactor.
73b9564 
ffi-buffer-make mandates returning a buffer.
@aadcg
recent-buffer: Delete buffer-match-predicate.
f934d19
@aadcg
changelog: Mention bug fix.
82a82eb
@aadcg aadcg merged commit 0cd5071 into master Feb 2, 2024
1 check passed
@aadcg aadcg deleted the fix-recent-buffers branch February 2, 2024 07:56
@aadcg
Copy link
Member Author

aadcg commented Feb 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmercouris jmercouris jmercouris left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix commands reopen-last-buffer and reopen-buffer
2 participants
@aadcg @jmercouris