PLT-1759 | Refactor to use AtlasTypeRegistry to check for Duplicate Business Metadata Names #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor the check for uniqueness to use typeRegistry instead of querying un-indexed attribute from atlasGraph
anbarasantr
reviewed
Jul 29, 2024
| businessMetadataDef.getDisplayName(), DataTypes.TypeCategory.BUSINESS_METADATA); | ||
| if (ret != null && ( | ||
| businessMetadataDef.getGuid() == null || !businessMetadataDef.getGuid().equals(ret.getProperty(Constants.GUID_PROPERTY_KEY, String.class)))) { | ||
| AtlasBusinessMetadataType ret = typeRegistry.getBusinessMetadataTypeByDisplayName(businessMetadataDef.getDisplayName()); |
There was a problem hiding this comment.
Possible to cover this with an unit test??
If we don't have any existing tests, we can add one
There was a problem hiding this comment.
@anbarasantr Yes. Right now we don't cover this via Unit test. But should be able to do. Will add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a performance issue identified on one of the Customer calls that creation of Custom Metadata was slow and adding Attributes to the Metadata was overshooting the allocated 30 seconds timeout on UI.
This led to investigation on identifying performance bottleneck for
The postmortem of the above is available here:
https://www.notion.so/atlanhq/Postmortem-Atlas-slowness-for-Custom-metadata-2b80ea2464044d4a95b66e92a6eeb433?pvs=4
One of the alternatives to solve this was suggested by @mehtaanshul to use AtlasTypeRegistry rather than traversing un-indexed graph store.