Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag cleanup task to cleanup all tags related to the #3138

Merged
merged 14 commits into from
May 27, 2024

Conversation

sumandas0
Copy link

@sumandas0 sumandas0 commented May 22, 2024

PLT-1625 : Add a background task to cleanup all the tags attached to assets efficiently

Right now if a customer has mistakenly propagated to large no of assets multiple time then we have to create multiple delete task to do this. Can we optimize this more so that we just do this once per asset and so this in one go? This PR will add this feature where it will remove all the attachment based on tag not tag attachment. https://atlanhq.atlassian.net/browse/PLT-1625

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix [https://atlanhq.atlassian.net/browse/PES-2065](tag propagation tasks stuck.)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable


AtlasEntity entity = repairClassificationMappings(vertex);

entityChangeNotifier.onClassificationDeletedFromEntity(entity, deletedClassifications);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the exact same notification that's sent when the classification is normally remove from an entity (both direct and propagation). Verify entity audits as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified : For notification it just publish classification deletion event. But in case of audit it calculate during publish time if this propagated or not, so it correctly send audits.

@sumandas0 sumandas0 merged commit 821de7c into master May 27, 2024
4 checks passed
@sumandas0 sumandas0 deleted the tag-cleanup-task branch May 27, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants