Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVENT-49: replace argo-dataflow to numaflow #49

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

si3nloong
Copy link

@si3nloong si3nloong commented Oct 21, 2022

This PR basically replaces the pipeline template of argo-dataflow with numaflow pipeline template.

@si3nloong si3nloong changed the title EVENT-46: replace argo-dataflow to numaflow EVENT-49: replace argo-dataflow to numaflow Oct 21, 2022
@linear
Copy link

linear bot commented Oct 21, 2022

EVENT-49

@atlanhq atlanhq deleted a comment from linear bot Oct 21, 2022
@si3nloong si3nloong marked this pull request as ready for review October 25, 2022 09:42
Copy link
Contributor

@louisnow louisnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please support both pipeline types: Dataflow and Numaflow until we are ready to move permanently

@si3nloong si3nloong marked this pull request as draft November 10, 2022 05:35
@@ -68,7 +68,7 @@ class PackageInfo {
* @returns {string}
*/
getPackageLabel() {
return `${constants.ARGOPM_LIBRARY_NAME_LABEL}=${encode(this.name)}`;
return `${constants.ARGOPM_LIBRARY_NAME_LABEL}=${specialEncode(this.name)}`;
Copy link
Contributor

@louisnow louisnow Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make this change? Is it safe/backwards compatible, etc?

Copy link
Author

@si3nloong si3nloong Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do aware this might be a bug in the current argopm (0.8.5). You can refer to the following:

  1. When I run argopm list -n default

Screenshot 2022-11-11 at 3 08 51 PM

  1. When I run argopm info @atlan/mssql -n default, it throw error instead. As you can see the second screenshot, the URL passed over is /k8s/clusters/c-kzq84/apis/dataflow.argoproj.io/v1alpha1/namespaces/default/pipelines?pretty=&allowWatchBookmarks=&continue=&fieldSelector=&labelSelector=package.argoproj.io/name=-atlan-mssql

Screenshot 2022-11-11 at 3 13 02 PM

Screenshot 2022-11-11 at 3 14 27 PM

Screenshot 2022-11-14 at 1 34 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants