Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove buffer from src/hdr buffer list if the buffer is killed #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x17de
Copy link

@0x17de 0x17de commented Jun 27, 2019

Once the buffer was killed it should be removed from the list of source and header buffers; Otherwise a new call to cmake-ide-run-cmake will cause minor issues since the file is closed while trying to apply new flags.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 297

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 68.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmake-ide.el 1 4 25.0%
Totals Coverage Status
Change from base Build 296: -0.3%
Covered Lines: 383
Relevant Lines: 561

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 297

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 68.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmake-ide.el 1 4 25.0%
Totals Coverage Status
Change from base Build 296: -0.3%
Covered Lines: 383
Relevant Lines: 561

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 297

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 68.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmake-ide.el 1 4 25.0%
Totals Coverage Status
Change from base Build 296: -0.3%
Covered Lines: 383
Relevant Lines: 561

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 297

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 68.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmake-ide.el 1 4 25.0%
Totals Coverage Status
Change from base Build 296: -0.3%
Covered Lines: 383
Relevant Lines: 561

💛 - Coveralls

@atilaneves
Copy link
Owner

Looks good, but could you add a test please? I don't want a regression for this to be introduced.

@0x17de
Copy link
Author

0x17de commented Jul 14, 2019

@atilaneves If you give me some more time I can write some test for that (maybe around late august). It could be that i need ert-async since i need to wait until cmake is successfully run

@atilaneves
Copy link
Owner

@0x17de Sure, it's your fix, so whenever you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants