Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the proximate issue of #9, by adding {lubridate}, {ggplot2}, {sf}, and {sp} as Imports dependencies of {lutz}. As functions from these packages are used via
pkg::foo()
calls, the respective packages should be in Imports and not Suggests. While one or two functions checked to see if {sf} or {sp} were installed, this is not implemented package-wide. Instead I made the relevant package explicit Imports and further I explicitly imported the used functions from their respective packages via@importFrom
statements in the {roxygen} markup.I also fixed all tractable issues that raised Notes or worse under
R CMD check
.Additionally, this PR fixes all failed tests.
Note that this PR won't make {lutz} CRAN-ready; {sp} is about to be deprecated and there are certainly messages about this in the check outputs. I'm not sure what CRAN intends or what is needed for that, but fixing that issue doesn't change the need for the changes addressed here.